Lab 3: Review Notes / Potential Issues #5

New Issue

2025-09-01T17:49:41+02:00

PickleRick commented

2025-09-01 17:49:41 +02:00

JSTK: RGB LED write is not atomic;
Mute: (IF s_axis_tvalid = '1' AND m_axis_tready = '1' THEN) → incorrect AXI check. Should check s_axis_tready instead. Current logic waits for m_axis_tready to assert valid. Would be correct if s_axis_tready were directly connected to m_axis_tready.
Volume Controller: Waits for m_axis_tready to assert valid (IF s_axis_tvalid = '1' AND m_axis_tready = '1' THEN).
Balance: Same AXI issue as above.

- **JSTK:** RGB LED write is not atomic; - **Mute:** `(IF s_axis_tvalid = '1' AND m_axis_tready = '1' THEN)` → incorrect AXI check. Should check `s_axis_tready` instead. Current logic waits for `m_axis_tready` to assert valid. Would be correct if `s_axis_tready` were directly connected to `m_axis_tready`. - **Volume Controller:** Waits for `m_axis_tready` to assert valid (`IF s_axis_tvalid = '1' AND m_axis_tready = '1' THEN`). - **Balance:** Same AXI issue as above.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: PickleRick/DESD#5